Messages in this thread |  | | Date | Mon, 18 Apr 2022 00:02:54 +0100 (BST) | From | "Maciej W. Rozycki" <> | Subject | Re: [RESEND][PATCH v3 1/2] serial: 8250: Fold EndRun device support into OxSemi Tornado code |
| |
On Fri, 15 Apr 2022, Greg Kroah-Hartman wrote:
> > Index: linux-macro/include/linux/pci_ids.h > > =================================================================== > > --- linux-macro.orig/include/linux/pci_ids.h > > +++ linux-macro/include/linux/pci_ids.h > > @@ -2622,6 +2622,9 @@ > > #define PCI_DEVICE_ID_DCI_PCCOM8 0x0002 > > #define PCI_DEVICE_ID_DCI_PCCOM2 0x0004 > > > > +#define PCI_VENDOR_ID_ENDRUN 0x7401 > > +#define PCI_DEVICE_ID_ENDRUN_1588 0xe100 > > As per the top of this file, this should not be needed here as you are > only using it in one file. Please leave it as-is.
I find this requirement silly, but here it's not the place to discuss it, so I have removed this part as requested. At least it's not inline magic numbers here.
Maciej
|  |