Messages in this thread |  | | Date | Sat, 16 Apr 2022 09:55:19 +0200 | Subject | Re: [PATCH v2 0/4] tools/thermal: thermal library and tools | From | Daniel Lezcano <> |
| |
Hi Srinivas,
On 16/04/2022 05:50, srinivas pandruvada wrote: > On Wed, 2022-04-13 at 10:21 -0700, srinivas pandruvada wrote: >> On Wed, 2022-04-13 at 17:06 +0200, Rafael J. Wysocki wrote: >>> On Wed, Apr 6, 2022 at 4:44 PM Daniel Lezcano < >>> daniel.lezcano@linaro.org> wrote: >>>> >>>> On 06/04/2022 16:28, srinivas pandruvada wrote: >>>>> Hi Daniel, >>>>> >>>>> On Wed, 2022-04-06 at 10:00 +0200, Daniel Lezcano wrote: >>>>>> >>>>>> Hi, >>>>>> >>>>>> if there is no comment for the series, shall I pick it so we >>>>>> can go >>>>>> forward ? >>>>> Didn't get time to check yet. It will still be for the next merge >>>>> window, correct? >>>> >>>> Right, but I would like to continue adding more features, scripts >>>> and >>>> tests. Iteratively. >>> >>> Srinivas, if you can give this a go, please, it will help. >>> >>> Otherwise, I think that all of your comments so far have been >>> addressed, or have I missed anything? >>> >> I will provide by the end of this week. > > 1. Some warnings in applying patch > > Applying: tools/lib/thermal: Add a thermal library > Applying: tools/thermal: Add util library > Applying: tools/thermal: A temperature capture tool > .git/rebase-apply/patch:795: space before tab in indent. > polling = 100; } > .git/rebase-apply/patch:90: new blank line at EOF. > + > .git/rebase-apply/patch:221: new blank line at EOF. > + > warning: 3 lines add whitespace errors. > Applying: tools/thermal: Add thermal daemon skeleton > .git/rebase-apply/patch:86: new blank line at EOF. > + > warning: 1 line adds whitespace errors.
Strange, I did not have those but I'll try to reproduce
> 2. Thermometer is fine > > 3. segfault for thermal-engine > > LD_LIBRARY_PATH=../lib:../../lib/thermal:$LD_LIBRARY_pATH ./thermal- > engine > Segmentation fault (core dumped) > root@srinivas-otcpl-icl-u:~/development/linux/tools/thermal/thermal- > engine# LD_LIBRARY_PATH=../lib:../../lib/thermal:$LD_LIBRARY_pATH > ./thermal-engine --help > thermal-engine : A thermal monitoring engine based on notifications > Usage: thermal-engine [options] > -h, --help this help > -d, --daemonize capture duration > -l <level>, --loglevel <level> log level: DEBUG, INFO, > NOTICE, WARN, ERROR > -s, --syslog output to syslog > > root@srinivas-otcpl-icl-u:~/development/linux/tools/thermal/thermal- > engine# LD_LIBRARY_PATH=../lib:../../lib/thermal:$LD_LIBRARY_pATH > ./thermal-engine -l DEBUG > Segmentation fault (core dumped) > root@srinivas-otcpl-icl-u:~/development/linux/tools/thermal/thermal- > engine# LD_LIBRARY_PATH=../lib:../../lib/thermal:$LD_LIBRARY_pATH > ./thermal-engine --loglevel DEBUG > Segmentation fault (core dumped) > root@srinivas-otcpl-icl-u:~/development/linux/tools/thermal/thermal- > engine# LD_LIBRARY_PATH=../lib:../../lib/thermal:$LD_LIBRARY_pATH > ./thermal-engine -s > Segmentation fault (core dumped)
Is CONFIG_THERMAL_NETLINK set ?
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
|  |