Messages in this thread |  | | Date | Sat, 16 Apr 2022 12:39:13 -0700 | Subject | Re: [PATCH net-next v4 03/18] net: dsa: sja1105: reorder sja1105_first_entry_longer_than with memory allocation | From | Florian Fainelli <> |
| |
On 4/15/2022 5:29 AM, Jakob Koschel wrote: > From: Vladimir Oltean <vladimir.oltean@nxp.com> > > sja1105_first_entry_longer_than() does not make use of the full struct > sja1105_gate_entry *e, just of e->interval which is set from the passed > entry_time. > > This means that if there is a gate conflict, we have allocated e for > nothing, just to free it later. Reorder the memory allocation and the > function call, to avoid that and simplify the error unwind path. > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> > Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
|  |