lkml.org 
[lkml]   [2022]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next v6] net/ipv6: Introduce accept_unsolicited_na knob to implement router-side changes for RFC9131
From
On 4/15/22 15:34, Arun Ajith S wrote:
> +accept_unsolicited_na - BOOLEAN
> + Add a new neighbour cache entry in STALE state for routers on receiving an
> + unsolicited neighbour advertisement with target link-layer address option
> + specified. This is as per router-side behavior documented in RFC9131.
> + This has lower precedence than drop_unsolicited_na.
> +
> + ==== ====== ====== ==============================================
> + drop accept fwding behaviour
> + ---- ------ ------ ----------------------------------------------
> + 1 X X Drop NA packet and don't pass up the stack
> + 0 0 X Pass NA packet up the stack, don't update NC
> + 0 1 0 Pass NA packet up the stack, don't update NC
> + 0 1 1 Pass NA packet up the stack, and add a STALE
> + NC entry
> + ==== ====== ====== ==============================================
> +
> + This will optimize the return path for the initial off-link communication
> + that is initiated by a directly connected host, by ensuring that
> + the first-hop router which turns on this setting doesn't have to
> + buffer the initial return packets to do neighbour-solicitation.
> + The prerequisite is that the host is configured to send
> + unsolicited neighbour advertisements on interface bringup.
> + This setting should be used in conjunction with the ndisc_notify setting
> + on the host to satisfy this prerequisite.
> +
> + By default this is turned off.
> +

Looks good. htmldocs builds successfully and the table displayed properly.

Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>

However, I remind you the following:

- The patch changelogs should be put between the dashes (---) and diffstat.
I don't see the changelogs when I hit reply-all because you put them as
message signature (at very bottom of patch message).
- DON'T DO top-posting, DO configure your MUA to make reply text below
the quoted text instead.

--
An old man doll... just what I always wanted! - Clara

\
 
 \ /
  Last update: 2022-04-16 07:43    [W:0.074 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site