Messages in this thread |  | | Date | Sat, 16 Apr 2022 12:30:47 -0700 | Subject | Re: [net-next PATCH v2 2/4] drivers: net: dsa: qca8k: drop port_sts from qca8k_priv | From | Florian Fainelli <> |
| |
On 4/12/2022 10:30 AM, Ansuel Smith wrote: > Port_sts is a thing of the past for this driver. It was something > present on the initial implementation of this driver and parts of the > original struct were dropped over time. Using an array of int to store if > a port is enabled or not to handle PM operation seems overkill. Switch > and use a simple u8 to store the port status where each bit correspond > to a port. (bit is set port is enabled, bit is not set, port is disabled) > Also add some comments to better describe why we need to track port > status. > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
|  |