lkml.org 
[lkml]   [2022]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 2/5] fpga: fix for coding style issues
On Sat, Apr 16, 2022 at 07:07:16PM +0530, Nava kishore Manne wrote:
> fixes the below checks reported by checkpatch.pl
> Lines should not end with a '('
> Alignment should match open parenthesis

Please help format the commit log, like:

fixes the below checks reported by checkpatch.pl:

- Lines should not end with a '('
- Alignment should match open parenthesis

>
> Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com>

With the minor fixes, please add my Acked-by.

Acked-by: Xu Yilun <yilun.xu@intel.com>

> ---
> Changes for v2:
> -None.
> Changes for v3:
> -Fixed similar issue exists in "drivers/fpga/*".
> Changes for v4:
> -None.
>
> drivers/fpga/fpga-mgr.c | 4 ++--
> drivers/fpga/fpga-region.c | 7 ++++---
> 2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c
> index d49a9ce34568..a699cc8e2fa6 100644
> --- a/drivers/fpga/fpga-mgr.c
> +++ b/drivers/fpga/fpga-mgr.c
> @@ -151,8 +151,8 @@ static int fpga_mgr_write_init_buf(struct fpga_manager *mgr,
> if (!mgr->mops->initial_header_size)
> ret = fpga_mgr_write_init(mgr, info, NULL, 0);
> else
> - ret = fpga_mgr_write_init(
> - mgr, info, buf, min(mgr->mops->initial_header_size, count));
> + ret = fpga_mgr_write_init(mgr, info, buf,
> + min(mgr->mops->initial_header_size, count));
>
> if (ret) {
> dev_err(&mgr->dev, "Error preparing FPGA for writing\n");
> diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c
> index b0ac18de4885..3864bf4f8920 100644
> --- a/drivers/fpga/fpga-region.c
> +++ b/drivers/fpga/fpga-region.c
> @@ -18,9 +18,10 @@
> static DEFINE_IDA(fpga_region_ida);
> static struct class *fpga_region_class;
>
> -struct fpga_region *fpga_region_class_find(
> - struct device *start, const void *data,
> - int (*match)(struct device *, const void *))
> +struct fpga_region *fpga_region_class_find(struct device *start,
> + const void *data,
> + int (*match)(struct device *,
> + const void *))
> {
> struct device *dev;
>
> --
> 2.25.1

\
 
 \ /
  Last update: 2022-04-16 19:11    [W:0.086 / U:1.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site