Messages in this thread |  | | Date | Sat, 16 Apr 2022 13:57:33 +0300 | Subject | Re: [PATCH] staging: rtl8712: fix uninit-value "data" and "mac" | From | Pavel Skripkin <> |
| |
Hi Wang,
On 4/15/22 12:57, Wang Cheng wrote: > Hi Pavel, thx for your review. > > Sorry, this patch is just confined to fixing uninit-values with > modifying the original code as less as possible. It sounds good to > refactor r8712_usbctrl_vendorreq() with better API. >
I understand your idea, but this will just hide the real problem until syzbot hit it in different place. So, I believe, it's better to fix the root case instead of hiding local cases.
With regards, Pavel Skripkin
|  |