Messages in this thread Patch in this message |  | | Date | Sun, 10 Apr 2022 10:47:04 -0000 | From | "tip-bot2 for Jakob Koschel" <> | Subject | [tip: timers/core] clockevents: Use dedicated list iterator variable |
| |
The following commit has been merged into the timers/core branch of tip:
Commit-ID: 2966a9918dfab183a1cb6be6794981ebe2abff83 Gitweb: https://git.kernel.org/tip/2966a9918dfab183a1cb6be6794981ebe2abff83 Author: Jakob Koschel <jakobkoschel@gmail.com> AuthorDate: Thu, 31 Mar 2022 23:57:07 +02:00 Committer: Thomas Gleixner <tglx@linutronix.de> CommitterDate: Sun, 10 Apr 2022 12:38:45 +02:00
clockevents: Use dedicated list iterator variable
To move the list iterator variable into the list_for_each_entry_*() macro in the future it should be avoided to use the list iterator variable after the loop body.
To *never* use the list iterator variable after the loop it was concluded to use a separate iterator variable.
Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/ Link: https://lore.kernel.org/r/20220331215707.883957-1-jakobkoschel@gmail.com --- kernel/time/clockevents.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c index 003ccf3..5d85014 100644 --- a/kernel/time/clockevents.c +++ b/kernel/time/clockevents.c @@ -690,7 +690,7 @@ static ssize_t unbind_device_store(struct device *dev, { char name[CS_NAME_LEN]; ssize_t ret = sysfs_get_uname(buf, name, count); - struct clock_event_device *ce; + struct clock_event_device *ce = NULL, *iter; if (ret < 0) return ret; @@ -698,9 +698,10 @@ static ssize_t unbind_device_store(struct device *dev, ret = -ENODEV; mutex_lock(&clockevents_mutex); raw_spin_lock_irq(&clockevents_lock); - list_for_each_entry(ce, &clockevent_devices, list) { - if (!strcmp(ce->name, name)) { - ret = __clockevents_try_unbind(ce, dev->id); + list_for_each_entry(iter, &clockevent_devices, list) { + if (!strcmp(iter->name, name)) { + ret = __clockevents_try_unbind(iter, dev->id); + ce = iter; break; } }
|  |