Messages in this thread |  | | Date | Mon, 11 Apr 2022 01:50:15 +0000 | From | Tzung-Bi Shih <> | Subject | Re: [PATCH v5 2/2] watchdog: Add Renesas RZ/N1 Watchdog driver |
| |
On Fri, Apr 08, 2022 at 10:02:05PM +0200, Jean-Jacques Hiblot wrote: > From: Phil Edworthy <phil.edworthy@renesas.com> > > This is a driver for the standard WDT on the RZ/N1 devices. This WDT has > very limited timeout capabilities. However, it can reset the device. > To do so, the corresponding bits in the SysCtrl RSTEN register need to > be enabled. This is not done by this driver. > > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com> > Signed-off-by: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
With a minor comment: Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
> +static int rzn1_wdt_probe(struct platform_device *pdev) > +{ [...] > + wdt->wdtdev.timeout = DEFAULT_TIMEOUT; > + ret = watchdog_init_timeout(&wdt->wdtdev, 0, dev);
Could it drop the assignment if `ret` is unused?
|  |