[lkml]   [2022]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] dmaengine: imx-sdma: fix regression with uart scripts
On 2022-04-08 13:39, Vinod Koul wrote:
> 1. Patch title should reflect the change introduced, so the title is not
> apt, pls revise

In hindsight the title was not very descriptive. I will update and send
a v2. Maybe something like:

dmaengine: imx-sdma: fix init of uart scripts

> 2. Is this in response to rmk's report, if so, please add reported-by

No. I am not even aware of any report on this issue. I discovered the
issue on my own and found the problem commit by doing a bisect.

> 3. Lastly, I would like to see some tested by for this patch..

I have tested on imx5, imx6 and imx8 systems. I will add some brief
details of this to the commit message in the v2 patch. I am not sure if
I as the author should include a Tested-by tag.

>> Fixes: b98ce2f4e32b ("dmaengine: imx-sdma: add uart rom script")
> cc: stable ?

That sounds reasonable. I am relatively new to submitting kernel patches
and that thought never crossed by mind.


 \ /
  Last update: 2022-04-11 00:29    [W:0.125 / U:4.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site