Messages in this thread |  | | Subject | Re: [PATCH 5/5] tpm: tpm_tis_spi_slb_9670: implement set_reset and unset_reset functions | From | Lino Sanfilippo <> | Date | Sun, 10 Apr 2022 21:44:47 +0200 |
| |
On 10.04.22 at 19:18, Lukas Wunner wrote: > On Thu, Apr 07, 2022 at 01:18:49PM +0200, Lino Sanfilippo wrote: >> --- /dev/null >> +++ b/drivers/char/tpm/tpm_tis_spi_slb9670.c > [...] >> +int slb9670_spi_unset_reset(struct tpm_tis_data *data) > [...] >> +int slb9670_spi_set_reset(struct tpm_tis_data *data) > [...] >> +static const struct tpm_tis_phy_ops slb9670_spi_phy_ops = { >> + .read_bytes = tpm_tis_spi_read_bytes, >> + .write_bytes = tpm_tis_spi_write_bytes, >> + .read16 = tpm_tis_spi_read16, >> + .read32 = tpm_tis_spi_read32, >> + .write32 = tpm_tis_spi_write32, >> + .set_reset = slb9670_spi_set_reset, >> + .unset_reset = slb9670_spi_unset_reset, >> +}; > > 0-day is complaining that slb9670_spi_set_reset() / slb9670_spi_unset_reset() > are not declared static: > > https://lore.kernel.org/all/202204081357.8SfjQosI-lkp@intel.com/ > > Thanks, > > Lukas >
Right, I will fix this in the next version, thanks!
Regards, Lino
|  |