Messages in this thread |  | | Date | Sun, 10 Apr 2022 21:22:11 +0200 | Subject | Re: [PATCH v2 6/6] dt-bindings: dma: Convert Qualcomm BAM DMA binding to json format | From | Krzysztof Kozlowski <> |
| |
On 10/04/2022 19:50, Kuldeep Singh wrote: > Convert Qualcomm BAM DMA controller binding to DT schema format using > json schema.
Thank you for your patch. There is something to discuss/improve.
(...)
> + > + interrupts: > + maxItems: 1 > + > + iommus: > + minItems: 1 > + maxItems: 4
This is something new and it seems only one SoC defines it (not even one BAM version). I wonder whether this is actually correct or this particular version of BAM is slightly different. Maybe someone could clarify it, but if no - looks ok.
> + > + num-channels: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Indicates supported number of DMA channels in a remotely controlled bam. > + > + qcom,controlled-remotely: > + $ref: /schemas/types.yaml#/definitions/flag
type: boolean
> + description: > + Indicates that the bam is controlled by remote proccessor i.e. execution > + environment. > + > + qcom,ee: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Indicates the active Execution Environment identifier (0-7) used in the > + secure world.
maximum: 7
> + > + qcom,num-ees: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Indicates supported number of Execution Environments in a remotely > + controlled bam. > + > + qcom,powered-remotely: > + $ref: /schemas/types.yaml#/definitions/flag
type: boolean
> + description: > + Indicates that the bam is powered up by a remote processor but must be > + initialized by the local processor. > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - "#dma-cells" > + - interrupts > + - reg
clocks, clock-names, qcom-ee - these are required according to old bindings.
Best regards, Krzysztof
|  |