Messages in this thread |  | | From | Junwen Wu <> | Subject | Re: [PATCH v1] tty/sysrq: change the definition of sysrq_key_table's element to make it more readable | Date | Sun, 10 Apr 2022 08:01:31 +0000 |
| |
Dear Jiri Sorry ,sysrq_showallcpus_op etc. are not massive,but confused. "CONFIG_TRACING" make the definition of the sysrq_ftrace_dump outside sysrq_key_table but "CONFIG_SMP" make the definition of the sysrq_showallcpus_op inside sysrq_key_table. so unitify the code will make code more readable. wujunwen is realy my name,Junwen Wu is better.
Jiri, I plan to modify the commit message as follow: Subject: [PATCH v1] tty/sysrq: change the definition of sysrq_key_table's element to make it more readable
The definition of sysrq_key_table's elements, like sysrq_thaw_op and sysrq_showallcpus_op are not consistent with sysrq_ftrace_dump_op, Consistency makes code more readable.
Signed-off-by: Junwen Wu <wudaemon@163.com>
Is this ok?
beside,if this commit message is ok,the subject will comment PATCH v2 ?
Thanks
|  |