lkml.org 
[lkml]   [2022]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 04/45] objtool,efi: Update __efi64_thunk annotation
> --- a/arch/x86/platform/efi/efi_thunk_64.S
> +++ b/arch/x86/platform/efi/efi_thunk_64.S
> @@ -20,12 +20,14 @@
> */
>
> #include <linux/linkage.h>
> +#include <linux/objtool.h>
> #include <asm/page_types.h>
> #include <asm/segment.h>
>
> .text
> .code64
> -SYM_CODE_START(__efi64_thunk)
> +SYM_FUNC_START(__efi64_thunk)
> +STACK_FRAME_NON_STANDARD __efi64_thunk

I would prefer if STACK_FRAME_NON_STANDARD annotation...

> push %rbp
> push %rbx
>
> @@ -79,7 +81,7 @@ SYM_CODE_START(__efi64_thunk)
> 2: pushl $__KERNEL_CS
> pushl %ebp
> lret
> -SYM_CODE_END(__efi64_thunk)
> +SYM_FUNC_END(__efi64_thunk)

went here after SYM_FUNC_END(), but that is just a cosmetic nit.

Miroslav

\
 
 \ /
  Last update: 2022-03-09 09:39    [W:0.392 / U:0.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site