lkml.org 
[lkml]   [2022]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 2/2] usb: typec: fix memory leak
Date
From: Yeqi Fu <fuyq@stu.pku.edu.cn>

Resource release is needed on the error handling branch
to prevent memory leak. Fix this by adding kfree to the
error handling branch.

Signed-off-by: Yeqi Fu <fuyq@stu.pku.edu.cn>
---
drivers/usb/typec/class.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
index ee0e520707dd..e210109c696d 100644
--- a/drivers/usb/typec/class.c
+++ b/drivers/usb/typec/class.c
@@ -2099,6 +2099,7 @@ struct typec_port *typec_register_port(struct device *parent,
port->cap = kmemdup(cap, sizeof(*cap), GFP_KERNEL);
if (!port->cap) {
put_device(&port->dev);
+ kfree(port);
return ERR_PTR(-ENOMEM);
}

@@ -2106,6 +2107,7 @@ struct typec_port *typec_register_port(struct device *parent,
if (IS_ERR(port->sw)) {
ret = PTR_ERR(port->sw);
put_device(&port->dev);
+ kfree(port);
return ERR_PTR(ret);
}

@@ -2113,6 +2115,7 @@ struct typec_port *typec_register_port(struct device *parent,
if (IS_ERR(port->mux)) {
ret = PTR_ERR(port->mux);
put_device(&port->dev);
+ kfree(port);
return ERR_PTR(ret);
}

@@ -2120,6 +2123,7 @@ struct typec_port *typec_register_port(struct device *parent,
if (ret) {
dev_err(parent, "failed to register port (%d)\n", ret);
put_device(&port->dev);
+ kfree(port);
return ERR_PTR(ret);
}

--
2.30.2
\
 
 \ /
  Last update: 2022-03-08 07:58    [W:0.090 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site