lkml.org 
[lkml]   [2022]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v18 4/8] regulator: sy7636a: Remove requirement on sy7636a mfd
    Hi Alistair,

    On Mon, Jan 24, 2022 at 1:25 PM Alistair Francis <alistair@alistair23.me> wrote:
    > Signed-off-by: Alistair Francis <alistair@alistair23.me>
    > Acked-by: Mark Brown <broonie@kernel.org>

    Thanks for your patch, which is now commit 947d0cce70ae37b8
    ("regulator: sy7636a: Remove requirement on sy7636a mfd") in
    mfd/for-mfd-next.

    > --- a/drivers/regulator/Kconfig
    > +++ b/drivers/regulator/Kconfig
    > @@ -1208,7 +1208,6 @@ config REGULATOR_STW481X_VMMC
    >
    > config REGULATOR_SY7636A
    > tristate "Silergy SY7636A voltage regulator"
    > - depends on MFD_SY7636A

    As this is an i2c mfd device, you still need a dependency on
    MFD and I2C, or some other symbol?

    > help
    > This driver supports Silergy SY3686A voltage regulator.
    >
    > diff --git a/drivers/regulator/sy7636a-regulator.c b/drivers/regulator/sy7636a-regulator.c
    > index 22fddf868e4c..29fc27c2cda0 100644
    > --- a/drivers/regulator/sy7636a-regulator.c
    > +++ b/drivers/regulator/sy7636a-regulator.c
    > @@ -7,11 +7,14 @@
    > // Authors: Lars Ivar Miljeteig <lars.ivar.miljeteig@remarkable.com>
    > // Alistair Francis <alistair@alistair23.me>
    >
    > +#include <linux/gpio/consumer.h>
    > +#include <linux/i2c.h>
    > +#include <linux/mfd/sy7636a.h>
    > #include <linux/module.h>
    > #include <linux/platform_device.h>
    > +#include <linux/regulator/driver.h>
    > +#include <linux/regulator/machine.h>
    > #include <linux/regmap.h>
    > -#include <linux/gpio/consumer.h>
    > -#include <linux/mfd/sy7636a.h>
    >
    > struct sy7636a_data {
    > struct regmap *regmap;

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    \
     
     \ /
      Last update: 2022-03-08 12:03    [W:4.057 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site