lkml.org 
[lkml]   [2022]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v18 2/8] mfd: simple-mfd-i2c: Add a Kconfig name
    Hi Alistair,

    Thanks for your patch, which is now commit bae5a4acef67db88
    ("mfd: simple-mfd-i2c: Add a Kconfig name") in mfd/for-mfd-next.

    On Mon, Jan 24, 2022 at 1:24 PM Alistair Francis <alistair@alistair23.me> wrote:
    > Add a Kconfig name to the "Simple Multi-Functional Device support (I2C)"
    > device so that it can be enabled via menuconfig.

    Which still does not explain why this would be needed...

    > Signed-off-by: Alistair Francis <alistair@alistair23.me>
    > Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>

    > --- a/drivers/mfd/Kconfig
    > +++ b/drivers/mfd/Kconfig
    > @@ -1188,7 +1188,7 @@ config MFD_SI476X_CORE
    > module will be called si476x-core.
    >
    > config MFD_SIMPLE_MFD_I2C
    > - tristate
    > + tristate "Simple Multi-Functional Device support (I2C)"
    > depends on I2C
    > select MFD_CORE
    > select REGMAP_I2C

    The help text states:

    | This driver creates a single register map with the intention for it
    | to be shared by all sub-devices.

    Yes, that's what MFD does?

    | Once the register map has been successfully initialised, any
    | sub-devices represented by child nodes in Device Tree will be
    | subsequently registered.

    OK...?

    Still, no clue about what this driver really does, and why and when
    it would be needed.

    There is one driver symbol that selects MFD_SIMPLE_MFD_I2C.
    There are no driver symbols that depend on this symbol.

    If you have a driver in the pipeline that can make use of this,
    can't it just select MFD_SIMPLE_MFD_I2C, so the symbol itself can
    stay invisible?

    Thanks!

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    \
     
     \ /
      Last update: 2022-03-08 11:55    [W:3.440 / U:0.304 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site