lkml.org 
[lkml]   [2022]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v3 1/1] device property: Allow error pointer to be passed to fwnode APIs
Date
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Sent: Tuesday, March 8, 2022 11:10 AM
> To: Sa, Nuno <Nuno.Sa@analog.com>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>; linux-
> acpi@vger.kernel.org; linux-kernel@vger.kernel.org; Daniel Scally
> <djrscally@gmail.com>; Heikki Krogerus
> <heikki.krogerus@linux.intel.com>; Sakari Ailus
> <sakari.ailus@linux.intel.com>; Greg Kroah-Hartman
> <gregkh@linuxfoundation.org>; Rafael J. Wysocki
> <rafael@kernel.org>; Len Brown <lenb@kernel.org>
> Subject: Re: [PATCH v3 1/1] device property: Allow error pointer to be
> passed to fwnode APIs
>
> [External]
>
> On Tue, Mar 08, 2022 at 09:25:07AM +0000, Sa, Nuno wrote:
> > > -----Original Message-----
> > > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > Sent: Monday, March 7, 2022 9:30 PM
>
> ...
>
> > > v3: dropped test of secondary fwnode (Nuno), added tag (Nuno),
> > > amended commit message
> > > v2: adjusted the entire fwnode API (Sakari)
> > >
> > > Nuno, can you re-test this with the ltc2983 series to be sure it is still
> > > okay?
> >
> > Still works!
>
> Thanks for confirming!
>
> ...
>
> > > @@ -988,14 +998,14 @@
> fwnode_graph_get_next_endpoint(const
> > > struct fwnode_handle *fwnode,
> > > parent = fwnode_graph_get_port_parent(prev);
> > > else
> > > parent = fwnode;
> > > + if (IS_ERR_OR_NULL(parent))
> > > + return NULL;
>
> (1)
>
> > > ep = fwnode_call_ptr_op(parent, graph_get_next_endpoint,
> > > prev);
> > > + if (ep)
> > > + return ep;
> >
> > I might be missing something but before the check being done was
> > 'if (IS_ERR_OR_NULL(ep)'. Is there anyway for ep to be an error
> > pointer? Looking at OF, It seems that only NULL or a valid pointer
> > is being returned. Did not looked at others implementations of
> > though...
>
> Yes, the IS_ERR() part is redundant there. I was quite confused with
> that code while working on this change. So, now it looks much clearer
> what's going on and what kind of values are being expected. This also
> justifies the choice of returned value in (1).
>

Makes sense to me.

Acked-by: Nuno Sá <nuno.sa@analog.com>

> --
> With Best Regards,
> Andy Shevchenko
>

\
 
 \ /
  Last update: 2022-03-08 11:33    [W:0.063 / U:0.780 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site