lkml.org 
[lkml]   [2022]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [PATCH v2 -next] powerpc/spufs: Fix build warning when CONFIG_PROC_FS=n
Date


Le 08/03/2022 à 11:09, YueHaibing a écrit :
> arch/powerpc/platforms/cell/spufs/sched.c:1055:12: warning: ‘show_spu_loadavg’ defined but not used [-Wunused-function]
> static int show_spu_loadavg(struct seq_file *s, void *private)
> ^~~~~~~~~~~~~~~~
>
> Move it into #ifdef block to fix this, also remove unneeded semicolon.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>

> ---
> v2: use #ifdef instead of __maybe_unused
> ---
> arch/powerpc/platforms/cell/spufs/sched.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/cell/spufs/sched.c b/arch/powerpc/platforms/cell/spufs/sched.c
> index d058f6233e66..99bd027a7f7c 100644
> --- a/arch/powerpc/platforms/cell/spufs/sched.c
> +++ b/arch/powerpc/platforms/cell/spufs/sched.c
> @@ -1052,6 +1052,7 @@ void spuctx_switch_state(struct spu_context *ctx,
> }
> }
>
> +#ifdef CONFIG_PROC_FS
> static int show_spu_loadavg(struct seq_file *s, void *private)
> {
> int a, b, c;
> @@ -1073,7 +1074,8 @@ static int show_spu_loadavg(struct seq_file *s, void *private)
> atomic_read(&nr_spu_contexts),
> idr_get_cursor(&task_active_pid_ns(current)->idr) - 1);
> return 0;
> -};
> +}
> +#endif
>
> int __init spu_sched_init(void)
> {
\
 
 \ /
  Last update: 2022-03-08 11:18    [W:0.064 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site