lkml.org 
[lkml]   [2022]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 3/4] perf: Refactor perf script branch stack printing
From


On 3/7/22 22:49, James Clark wrote:
> Remove duplicate code so that future changes to flags are always made to
> all 3 printing variations.
>
> Signed-off-by: James Clark <james.clark@arm.com>
> ---
> tools/perf/builtin-script.c | 27 ++++++++++++---------------
> 1 file changed, 12 insertions(+), 15 deletions(-)
>
> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> index 9e032343f1c6..fac2e9470926 100644
> --- a/tools/perf/builtin-script.c
> +++ b/tools/perf/builtin-script.c
> @@ -857,6 +857,15 @@ mispred_str(struct branch_entry *br)
> return br->flags.predicted ? 'P' : 'M';
> }
>
> +static int print_bstack_flags(FILE *fp, struct branch_entry *br)
> +{
> + return fprintf(fp, "/%c/%c/%c/%d ",
> + mispred_str(br),
> + br->flags.in_tx ? 'X' : '-',
> + br->flags.abort ? 'A' : '-',
> + br->flags.cycles);
> +}
> +
> static int perf_sample__fprintf_brstack(struct perf_sample *sample,
> struct thread *thread,
> struct perf_event_attr *attr, FILE *fp)
> @@ -895,11 +904,7 @@ static int perf_sample__fprintf_brstack(struct perf_sample *sample,
> printed += fprintf(fp, ")");
> }
>
> - printed += fprintf(fp, "/%c/%c/%c/%d ",
> - mispred_str(entries + i),
> - entries[i].flags.in_tx ? 'X' : '-',
> - entries[i].flags.abort ? 'A' : '-',
> - entries[i].flags.cycles);
> + printed += print_bstack_flags(fp, entries + i);
> }
>
> return printed;
> @@ -941,11 +946,7 @@ static int perf_sample__fprintf_brstacksym(struct perf_sample *sample,
> printed += map__fprintf_dsoname(alt.map, fp);
> printed += fprintf(fp, ")");
> }
> - printed += fprintf(fp, "/%c/%c/%c/%d ",
> - mispred_str(entries + i),
> - entries[i].flags.in_tx ? 'X' : '-',
> - entries[i].flags.abort ? 'A' : '-',
> - entries[i].flags.cycles);
> + printed += print_bstack_flags(fp, entries + i);
> }
>
> return printed;
> @@ -991,11 +992,7 @@ static int perf_sample__fprintf_brstackoff(struct perf_sample *sample,
> printed += map__fprintf_dsoname(alt.map, fp);
> printed += fprintf(fp, ")");
> }
> - printed += fprintf(fp, "/%c/%c/%c/%d ",
> - mispred_str(entries + i),
> - entries[i].flags.in_tx ? 'X' : '-',
> - entries[i].flags.abort ? 'A' : '-',
> - entries[i].flags.cycles);
> + printed += print_bstack_flags(fp, entries + i);
> }
>
> return printed;


LGTM

Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>

\
 
 \ /
  Last update: 2022-03-08 06:06    [W:0.101 / U:1.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site