lkml.org 
[lkml]   [2022]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH V4 3/7] mmc: debugfs: Add debug fs entry for mmc driver
From
On 2.3.2022 15.03, Shaik Sajida Bhanu wrote:
> Add debug fs entry to query eMMC and SD card errors statistics
>
> Signed-off-by: Liangliang Lu <quic_luliang@quicinc.com>
> Signed-off-by: Sayali Lokhande <quic_sayalil@quicinc.com>
> Signed-off-by: Bao D. Nguyen <quic_nguyenb@quicinc.com>
> Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
> ---
> drivers/mmc/core/debugfs.c | 60 ++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 60 insertions(+)
>
> diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c
> index 3fdbc80..db0988c 100644
> --- a/drivers/mmc/core/debugfs.c
> +++ b/drivers/mmc/core/debugfs.c
> @@ -223,6 +223,63 @@ static int mmc_clock_opt_set(void *data, u64 val)
> DEFINE_DEBUGFS_ATTRIBUTE(mmc_clock_fops, mmc_clock_opt_get, mmc_clock_opt_set,
> "%llu\n");
>
> +static int mmc_err_stats_show(struct seq_file *file, void *data)
> +{
> + struct mmc_host *host = (struct mmc_host *)file->private;
> + const char *desc[MMC_ERR_MAX] = {
> + [MMC_ERR_CMD_TIMEOUT] = "Command Timeout Occurred",
> + [MMC_ERR_CMD_CRC] = "Command CRC Errors Occurred",
> + [MMC_ERR_DAT_TIMEOUT] = "Data Timeout Occurred",
> + [MMC_ERR_DAT_CRC] = "Data CRC Errors Occurred",
> + [MMC_ERR_AUTO_CMD] = "Auto-Cmd Error Occurred",
> + [MMC_ERR_ADMA] = "ADMA Error Occurred",
> + [MMC_ERR_TUNING] = "Tuning Error Occurred",
> + [MMC_ERR_CMDQ_RED] = "CMDQ RED Errors",
> + [MMC_ERR_CMDQ_GCE] = "CMDQ GCE Errors",
> + [MMC_ERR_CMDQ_ICCE] = "CMDQ ICCE Errors",
> + [MMC_ERR_REQ_TIMEOUT] = "Request Timedout",
> + [MMC_ERR_CMDQ_REQ_TIMEOUT] = "CMDQ Request Timedout",
> + [MMC_ERR_ICE_CFG] = "ICE Config Errors",
> + };
> + int i;
> +
> + if (!host)
> + return -EINVAL;

Do not need to check host here

> +
> + for (i = 0; i < MMC_ERR_MAX; i++) {
> + if (desc[i])
> + seq_printf(file, "# %s:\t %d\n",
> + desc[i], host->err_stats[i]);
> + }
> +
> + return 0;
> +}
> +
> +static int mmc_err_stats_open(struct inode *inode, struct file *file)
> +{
> + return single_open(file, mmc_err_stats_show, inode->i_private);
> +}
> +
> +static ssize_t mmc_err_stats_write(struct file *filp, const char __user *ubuf,
> + size_t cnt, loff_t *ppos)
> +{
> + struct mmc_host *host = filp->f_mapping->host->i_private;
> +
> + if (!host)
> + return -EINVAL;

Do not need to check host here

> +
> + pr_debug("%s: Resetting MMC error statistics\n", __func__);
> + memset(host->err_stats, 0, sizeof(host->err_stats));
> +
> + return cnt;
> +}
> +
> +static const struct file_operations mmc_err_stats_fops = {
> + .open = mmc_err_stats_open,
> + .read = seq_read,
> + .write = mmc_err_stats_write,
> +};
> +
> void mmc_add_host_debugfs(struct mmc_host *host)
> {
> struct dentry *root;
> @@ -236,6 +293,9 @@ void mmc_add_host_debugfs(struct mmc_host *host)
> debugfs_create_file_unsafe("clock", S_IRUSR | S_IWUSR, root, host,
> &mmc_clock_fops);
>
> + debugfs_create_file("err_stats", 0600, root, host,
> + &mmc_err_stats_fops);
> +
> #ifdef CONFIG_FAIL_MMC_REQUEST
> if (fail_request)
> setup_fault_attr(&fail_default_attr, fail_request);

\
 
 \ /
  Last update: 2022-03-08 10:50    [W:0.169 / U:1.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site