lkml.org 
[lkml]   [2022]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] drivers/hwmon: Use of_device_get_match_data()
Hi,

On Mon, Mar 07, 2022 at 03:36:31AM +0000, cgel.zte@gmail.com wrote:
> From: Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn>
>
> Use of_device_get_match_data() to simplify the code.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn>

This is not the first patch from issues reported by Zeal Robot
with an inappropriate subject. "drivers/hwmon:" doesn't say anything.
The subject should either be "<subsystem>: <driver>: <description>" or,
as commonly used in hwmon, "hwmon: (driver) <description". I fixed
the subject and applied the patch, but don't expect me to do this
again in the future.

Guenter

> ---
> drivers/hwmon/vexpress-hwmon.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/hwmon/vexpress-hwmon.c b/drivers/hwmon/vexpress-hwmon.c
> index 44d798be3d59..2ac5fb96bba4 100644
> --- a/drivers/hwmon/vexpress-hwmon.c
> +++ b/drivers/hwmon/vexpress-hwmon.c
> @@ -207,7 +207,6 @@ MODULE_DEVICE_TABLE(of, vexpress_hwmon_of_match);
>
> static int vexpress_hwmon_probe(struct platform_device *pdev)
> {
> - const struct of_device_id *match;
> struct vexpress_hwmon_data *data;
> const struct vexpress_hwmon_type *type;
>
> @@ -216,10 +215,9 @@ static int vexpress_hwmon_probe(struct platform_device *pdev)
> return -ENOMEM;
> platform_set_drvdata(pdev, data);
>
> - match = of_match_device(vexpress_hwmon_of_match, &pdev->dev);
> - if (!match)
> + type = of_device_get_match_data(&pdev->dev);
> + if (!type)
> return -ENODEV;
> - type = match->data;
>
> data->reg = devm_regmap_init_vexpress_config(&pdev->dev);
> if (IS_ERR(data->reg))

\
 
 \ /
  Last update: 2022-03-08 18:25    [W:5.248 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site