lkml.org 
[lkml]   [2022]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 187/262] auxdisplay: lcd2s: Use proper API to free the instance of charlcd object
    Date
    From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

    commit 9ed331f8a0fb674f4f06edf05a1687bf755af27b upstream.

    While it might work, the current approach is fragile in a few ways:
    - whenever members in the structure are shuffled, the pointer will be wrong
    - the resource freeing may include more than covered by kfree()

    Fix this by using charlcd_free() call instead of kfree().

    Fixes: 8c9108d014c5 ("auxdisplay: add a driver for lcd2s character display")
    Cc: Lars Poeschel <poeschel@lemonage.de>
    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/auxdisplay/lcd2s.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/auxdisplay/lcd2s.c
    +++ b/drivers/auxdisplay/lcd2s.c
    @@ -336,7 +336,7 @@ static int lcd2s_i2c_probe(struct i2c_cl
    return 0;

    fail1:
    - kfree(lcd);
    + charlcd_free(lcd2s->charlcd);
    return err;
    }

    @@ -345,7 +345,7 @@ static int lcd2s_i2c_remove(struct i2c_c
    struct lcd2s_data *lcd2s = i2c_get_clientdata(i2c);

    charlcd_unregister(lcd2s->charlcd);
    - kfree(lcd2s->charlcd);
    + charlcd_free(lcd2s->charlcd);
    return 0;
    }


    \
     
     \ /
      Last update: 2022-03-07 11:14    [W:5.141 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site