lkml.org 
[lkml]   [2022]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 5/7] tty: serial: samsung: constify s3c24xx_serial_drv_data members
From
On 04. 03. 22, 9:03, Krzysztof Kozlowski wrote:
> The driver data (struct s3c24xx_serial_drv_data) is never modified, so
> also its members can be make const. Except code style this has no

s/make/made/ if you do a v2.

> impact because the structure itself is always a const.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>

> ---
> drivers/tty/serial/samsung_tty.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
> index 279c413f2300..eecefff5c4a4 100644
> --- a/drivers/tty/serial/samsung_tty.c
> +++ b/drivers/tty/serial/samsung_tty.c
> @@ -85,9 +85,9 @@ struct s3c24xx_uart_info {
> };
>
> struct s3c24xx_serial_drv_data {
> - struct s3c24xx_uart_info info;
> - struct s3c2410_uartcfg def_cfg;
> - unsigned int fifosize[CONFIG_SERIAL_SAMSUNG_UARTS];
> + const struct s3c24xx_uart_info info;
> + const struct s3c2410_uartcfg def_cfg;
> + const unsigned int fifosize[CONFIG_SERIAL_SAMSUNG_UARTS];
> };
>
> struct s3c24xx_uart_dma {


--
js
suse labs

\
 
 \ /
  Last update: 2022-03-07 07:39    [W:0.063 / U:0.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site