lkml.org 
[lkml]   [2022]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 064/105] net: sxgbe: fix return value of __setup handler
    Date
    From: Randy Dunlap <rdunlap@infradead.org>

    commit 50e06ddceeea263f57fe92baa677c638ecd65bb6 upstream.

    __setup() handlers should return 1 on success, i.e., the parameter
    has been handled. A return of 0 causes the "option=value" string to be
    added to init's environment strings, polluting it.

    Fixes: acc18c147b22 ("net: sxgbe: add EEE(Energy Efficient Ethernet) for Samsung sxgbe")
    Fixes: 1edb9ca69e8a ("net: sxgbe: add basic framework for Samsung 10Gb ethernet driver")
    Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
    Reported-by: Igor Zhbanov <i.zhbanov@omprussia.ru>
    Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@omprussia.ru
    Cc: Siva Reddy <siva.kallam@samsung.com>
    Cc: Girish K S <ks.giri@samsung.com>
    Cc: Byungho An <bh74.an@samsung.com>
    Link: https://lore.kernel.org/r/20220224033528.24640-1-rdunlap@infradead.org
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    --- a/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c
    +++ b/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c
    @@ -2282,18 +2282,18 @@ static int __init sxgbe_cmdline_opt(char
    char *opt;

    if (!str || !*str)
    - return -EINVAL;
    + return 1;
    while ((opt = strsep(&str, ",")) != NULL) {
    if (!strncmp(opt, "eee_timer:", 10)) {
    if (kstrtoint(opt + 10, 0, &eee_timer))
    goto err;
    }
    }
    - return 0;
    + return 1;

    err:
    pr_err("%s: ERROR broken module parameter conversion\n", __func__);
    - return -EINVAL;
    + return 1;
    }

    __setup("sxgbeeth=", sxgbe_cmdline_opt);

    \
     
     \ /
      Last update: 2022-03-07 10:50    [W:4.077 / U:0.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site