lkml.org 
[lkml]   [2022]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 09/32] usb: gadget: dont release an existing dev->buf
    Date
    From: Hangyu Hua <hbh25y@gmail.com>

    commit 89f3594d0de58e8a57d92d497dea9fee3d4b9cda upstream.

    dev->buf does not need to be released if it already exists before
    executing dev_config.

    Acked-by: Alan Stern <stern@rowland.harvard.edu>
    Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
    Link: https://lore.kernel.org/r/20211231172138.7993-2-hbh25y@gmail.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/usb/gadget/legacy/inode.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/usb/gadget/legacy/inode.c
    +++ b/drivers/usb/gadget/legacy/inode.c
    @@ -1833,8 +1833,9 @@ dev_config (struct file *fd, const char
    spin_lock_irq (&dev->lock);
    value = -EINVAL;
    if (dev->buf) {
    + spin_unlock_irq(&dev->lock);
    kfree(kbuf);
    - goto fail;
    + return value;
    }
    dev->buf = kbuf;


    \
     
     \ /
      Last update: 2022-03-07 10:26    [W:3.746 / U:0.468 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site