lkml.org 
[lkml]   [2022]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 06/32] dmaengine: shdma: Fix runtime PM imbalance on error
    Date
    From: Yongzhi Liu <lyz_cs@pku.edu.cn>

    [ Upstream commit 455896c53d5b803733ddd84e1bf8a430644439b6 ]

    pm_runtime_get_() increments the runtime PM usage counter even
    when it returns an error code, thus a matching decrement is needed on
    the error handling path to keep the counter balanced.

    Signed-off-by: Yongzhi Liu <lyz_cs@pku.edu.cn>
    Link: https://lore.kernel.org/r/1642311296-87020-1-git-send-email-lyz_cs@pku.edu.cn
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/dma/sh/shdma-base.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/dma/sh/shdma-base.c b/drivers/dma/sh/shdma-base.c
    index 12fa48e380cf5..4f8dfe77da3c5 100644
    --- a/drivers/dma/sh/shdma-base.c
    +++ b/drivers/dma/sh/shdma-base.c
    @@ -118,8 +118,10 @@ static dma_cookie_t shdma_tx_submit(struct dma_async_tx_descriptor *tx)
    ret = pm_runtime_get(schan->dev);

    spin_unlock_irq(&schan->chan_lock);
    - if (ret < 0)
    + if (ret < 0) {
    dev_err(schan->dev, "%s(): GET = %d\n", __func__, ret);
    + pm_runtime_put(schan->dev);
    + }

    pm_runtime_barrier(schan->dev);

    --
    2.34.1


    \
     
     \ /
      Last update: 2022-03-07 10:25    [W:2.836 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site