lkml.org 
[lkml]   [2022]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 176/186] btrfs: do not WARN_ON() if we have PageError set
    Date
    From: Josef Bacik <josef@toxicpanda.com>

    commit a50e1fcbc9b85fd4e95b89a75c0884cb032a3e06 upstream.

    Whenever we do any extent buffer operations we call
    assert_eb_page_uptodate() to complain loudly if we're operating on an
    non-uptodate page. Our overnight tests caught this warning earlier this
    week

    WARNING: CPU: 1 PID: 553508 at fs/btrfs/extent_io.c:6849 assert_eb_page_uptodate+0x3f/0x50
    CPU: 1 PID: 553508 Comm: kworker/u4:13 Tainted: G W 5.17.0-rc3+ #564
    Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.13.0-2.fc32 04/01/2014
    Workqueue: btrfs-cache btrfs_work_helper
    RIP: 0010:assert_eb_page_uptodate+0x3f/0x50
    RSP: 0018:ffffa961440a7c68 EFLAGS: 00010246
    RAX: 0017ffffc0002112 RBX: ffffe6e74453f9c0 RCX: 0000000000001000
    RDX: ffffe6e74467c887 RSI: ffffe6e74453f9c0 RDI: ffff8d4c5efc2fc0
    RBP: 0000000000000d56 R08: ffff8d4d4a224000 R09: 0000000000000000
    R10: 00015817fa9d1ef0 R11: 000000000000000c R12: 00000000000007b1
    R13: ffff8d4c5efc2fc0 R14: 0000000001500000 R15: 0000000001cb1000
    FS: 0000000000000000(0000) GS:ffff8d4dbbd00000(0000) knlGS:0000000000000000
    CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
    CR2: 00007ff31d3448d8 CR3: 0000000118be8004 CR4: 0000000000370ee0
    Call Trace:

    extent_buffer_test_bit+0x3f/0x70
    free_space_test_bit+0xa6/0xc0
    load_free_space_tree+0x1f6/0x470
    caching_thread+0x454/0x630
    ? rcu_read_lock_sched_held+0x12/0x60
    ? rcu_read_lock_sched_held+0x12/0x60
    ? rcu_read_lock_sched_held+0x12/0x60
    ? lock_release+0x1f0/0x2d0
    btrfs_work_helper+0xf2/0x3e0
    ? lock_release+0x1f0/0x2d0
    ? finish_task_switch.isra.0+0xf9/0x3a0
    process_one_work+0x26d/0x580
    ? process_one_work+0x580/0x580
    worker_thread+0x55/0x3b0
    ? process_one_work+0x580/0x580
    kthread+0xf0/0x120
    ? kthread_complete_and_exit+0x20/0x20
    ret_from_fork+0x1f/0x30

    This was partially fixed by c2e39305299f01 ("btrfs: clear extent buffer
    uptodate when we fail to write it"), however all that fix did was keep
    us from finding extent buffers after a failed writeout. It didn't keep
    us from continuing to use a buffer that we already had found.

    In this case we're searching the commit root to cache the block group,
    so we can start committing the transaction and switch the commit root
    and then start writing. After the switch we can look up an extent
    buffer that hasn't been written yet and start processing that block
    group. Then we fail to write that block out and clear Uptodate on the
    page, and then we start spewing these errors.

    Normally we're protected by the tree lock to a certain degree here. If
    we read a block we have that block read locked, and we block the writer
    from locking the block before we submit it for the write. However this
    isn't necessarily fool proof because the read could happen before we do
    the submit_bio and after we locked and unlocked the extent buffer.

    Also in this particular case we have path->skip_locking set, so that
    won't save us here. We'll simply get a block that was valid when we
    read it, but became invalid while we were using it.

    What we really want is to catch the case where we've "read" a block but
    it's not marked Uptodate. On read we ClearPageError(), so if we're
    !Uptodate and !Error we know we didn't do the right thing for reading
    the page.

    Fix this by checking !Uptodate && !Error, this way we will not complain
    if our buffer gets invalidated while we're using it, and we'll maintain
    the spirit of the check which is to make sure we have a fully in-cache
    block while we're messing with it.

    CC: stable@vger.kernel.org # 5.4+
    Signed-off-by: Josef Bacik <josef@toxicpanda.com>
    Signed-off-by: David Sterba <dsterba@suse.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/btrfs/extent_io.c | 16 +++++++++++++---
    1 file changed, 13 insertions(+), 3 deletions(-)

    --- a/fs/btrfs/extent_io.c
    +++ b/fs/btrfs/extent_io.c
    @@ -6865,14 +6865,24 @@ static void assert_eb_page_uptodate(cons
    {
    struct btrfs_fs_info *fs_info = eb->fs_info;

    + /*
    + * If we are using the commit root we could potentially clear a page
    + * Uptodate while we're using the extent buffer that we've previously
    + * looked up. We don't want to complain in this case, as the page was
    + * valid before, we just didn't write it out. Instead we want to catch
    + * the case where we didn't actually read the block properly, which
    + * would have !PageUptodate && !PageError, as we clear PageError before
    + * reading.
    + */
    if (fs_info->sectorsize < PAGE_SIZE) {
    - bool uptodate;
    + bool uptodate, error;

    uptodate = btrfs_subpage_test_uptodate(fs_info, page,
    eb->start, eb->len);
    - WARN_ON(!uptodate);
    + error = btrfs_subpage_test_error(fs_info, page, eb->start, eb->len);
    + WARN_ON(!uptodate && !error);
    } else {
    - WARN_ON(!PageUptodate(page));
    + WARN_ON(!PageUptodate(page) && !PageError(page));
    }
    }


    \
     
     \ /
      Last update: 2022-09-17 16:16    [W:4.214 / U:0.876 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site