lkml.org 
[lkml]   [2022]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] ASoC: rk817: Fix missing clk_disable_unprepare() in rk817_platform_probe
On Mon, Mar 07, 2022 at 09:01:30AM +0000, Miaoqian Lin wrote:
> Fix the missing clk_disable_unprepare() before return
> from rk817_platform_probe() in the error handling case.
>
> Fixes: 0d6a04da9b25 ("ASoC: Add Rockchip rk817 audio CODEC support")

Tested-by: Chris Morgan <macromorgan@hotmail.com>

> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> sound/soc/codecs/rk817_codec.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/codecs/rk817_codec.c b/sound/soc/codecs/rk817_codec.c
> index 03f24edfe4f6..8fffe378618d 100644
> --- a/sound/soc/codecs/rk817_codec.c
> +++ b/sound/soc/codecs/rk817_codec.c
> @@ -508,12 +508,14 @@ static int rk817_platform_probe(struct platform_device *pdev)
> if (ret < 0) {
> dev_err(&pdev->dev, "%s() register codec error %d\n",
> __func__, ret);
> - goto err_;
> + goto err_clk;
> }
>
> return 0;
> -err_:
>
> +err_clk:
> + clk_disable_unprepare(rk817_codec_data->mclk);
> +err_:
> return ret;
> }
>
> --
> 2.17.1
>

\
 
 \ /
  Last update: 2022-03-08 03:17    [W:0.035 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site