lkml.org 
[lkml]   [2022]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] netfilter: conditionally use ct and ctinfo
Tom Rix <trix@redhat.com> wrote:
>
> On 3/7/22 4:46 AM, Florian Westphal wrote:
> > trix@redhat.com <trix@redhat.com> wrote:
> > > From: Tom Rix <trix@redhat.com>
> > >
> > > The setting ct and ctinfo are controlled by
> > > CONF_NF_CONNTRACK. So their use should also
> > > be controlled.
> > Any reason for this change?
>
> Define and use are connected. Doing something to one without doing something
> to the other doesn't make sense.

We often rely on compiler to remove branches that always evaluate to
false, just like in this case.

> Could removing the CONF_NF_CONNTRACK be done for the define side ?

Doubt it. Looking at git history it avoids build breakage.

\
 
 \ /
  Last update: 2022-03-07 22:55    [W:0.026 / U:1.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site