[lkml]   [2022]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH mmotm v2] mm: delete __ClearPageWaiters()
On 04.03.22 22:25, Hugh Dickins wrote:
> The PG_waiters bit is not included in PAGE_FLAGS_CHECK_AT_FREE, and
> vmscan.c's free_unref_page_list() callers rely on that not to generate
> bad_page() alerts. So __page_cache_release(), put_pages_list() and
> release_pages() (and presumably copy-and-pasted free_zone_device_page())
> are redundant and misleading to make a special point of clearing it (as
> the "__" implies, it could only safely be used on the freeing path).
> Delete __ClearPageWaiters(). Remark on this in one of the "possible"
> comments in folio_wake_bit(), and delete the superfluous comments.
> Signed-off-by: Hugh Dickins <>
> Tested-by: Yu Zhao <>


Reviewed-by: David Hildenbrand <>


David / dhildenb

 \ /
  Last update: 2022-03-07 09:42    [W:0.081 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site