lkml.org 
[lkml]   [2022]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 1/2] Revert "dt-bindings:drm/bridge:anx7625:add vendor define"
On Mon, Mar 07, 2022 at 04:45:57PM +0100, Robert Foss wrote:
> This reverts commit a43661e7e819b100e1f833a35018560a1d9abb39.

S-o-b and reason for the revert?

> ---
> .../display/bridge/analogix,anx7625.yaml | 65 +------------------
> 1 file changed, 2 insertions(+), 63 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> index 1d3e88daca041..ab48ab2f4240d 100644
> --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> @@ -43,70 +43,14 @@ properties:
> vdd33-supply:
> description: Regulator that provides the supply 3.3V power.
>
> - analogix,lane0-swing:
> - $ref: /schemas/types.yaml#/definitions/uint8-array
> - minItems: 1
> - maxItems: 20
> - description:
> - an array of swing register setting for DP tx lane0 PHY.
> - Registers 0~9 are Swing0_Pre0, Swing1_Pre0, Swing2_Pre0,
> - Swing3_Pre0, Swing0_Pre1, Swing1_Pre1, Swing2_Pre1, Swing0_Pre2,
> - Swing1_Pre2, Swing0_Pre3, they are for [Boost control] and
> - [Swing control] setting.
> - Registers 0~9, bit 3:0 is [Boost control], these bits control
> - post cursor manual, increase the [Boost control] to increase
> - Pre-emphasis value.
> - Registers 0~9, bit 6:4 is [Swing control], these bits control
> - swing manual, increase [Swing control] setting to add Vp-p value
> - for each Swing, Pre.
> - Registers 10~19 are Swing0_Pre0, Swing1_Pre0, Swing2_Pre0,
> - Swing3_Pre0, Swing0_Pre1, Swing1_Pre1, Swing2_Pre1, Swing0_Pre2,
> - Swing1_Pre2, Swing0_Pre3, they are for [R select control] and
> - [R Termination control] setting.
> - Registers 10~19, bit 4:0 is [R select control], these bits are
> - compensation manual, increase it can enhance IO driven strength
> - and Vp-p.
> - Registers 10~19, bit 5:6 is [R termination control], these bits
> - adjust 50ohm impedance of DP tx termination. 00:55 ohm,
> - 01:50 ohm(default), 10:45 ohm, 11:40 ohm.
> -
> - analogix,lane1-swing:
> - $ref: /schemas/types.yaml#/definitions/uint8-array
> - minItems: 1
> - maxItems: 20
> - description:
> - an array of swing register setting for DP tx lane1 PHY.
> - DP TX lane1 swing register setting same with lane0
> - swing, please refer lane0-swing property description.

These apply to the DP side, so no need to revert this part.

> -
> - analogix,audio-enable:
> - type: boolean
> - description: let the driver enable audio HDMI codec function or not.
> -

Not sure on this one...

> ports:
> $ref: /schemas/graph.yaml#/properties/ports
>
> properties:
> port@0:
> - $ref: /schemas/graph.yaml#/$defs/port-base
> - unevaluatedProperties: false
> + $ref: /schemas/graph.yaml#/properties/port
> description:
> - MIPI DSI/DPI input.
> -
> - properties:
> - endpoint:
> - $ref: /schemas/media/video-interfaces.yaml#
> - type: object
> - additionalProperties: false
> -
> - properties:
> - remote-endpoint: true
> -
> - bus-type:
> - enum: [1, 5]

I think the error here is really 1 should be 4 which corresponds to
D-PHY which is used by both CSI and DSI. Otherwise, I don't really see
the issue with bus-type being shared between CSI and DSI.

> - default: 1
> -
> - data-lanes: true
> + Video port for MIPI DSI input.
>
> port@1:
> $ref: /schemas/graph.yaml#/properties/port
> @@ -143,9 +87,6 @@ examples:
> vdd10-supply = <&pp1000_mipibrdg>;
> vdd18-supply = <&pp1800_mipibrdg>;
> vdd33-supply = <&pp3300_mipibrdg>;
> - analogix,audio-enable;
> - analogix,lane0-swing = /bits/ 8 <0x14 0x54 0x64 0x74>;
> - analogix,lane1-swing = /bits/ 8 <0x14 0x54 0x64 0x74>;
>
> ports {
> #address-cells = <1>;
> @@ -155,8 +96,6 @@ examples:
> reg = <0>;
> anx7625_in: endpoint {
> remote-endpoint = <&mipi_dsi>;
> - bus-type = <5>;
> - data-lanes = <0 1 2 3>;
> };
> };
>
> --
> 2.32.0
>
>

\
 
 \ /
  Last update: 2022-03-07 17:39    [W:0.085 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site