lkml.org 
[lkml]   [2022]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 3/7] tty: serial: samsung: constify s3c24xx_serial_drv_data
From
On 07. 03. 22, 9:09, Krzysztof Kozlowski wrote:
> The driver data (struct s3c24xx_serial_drv_data) is only used to
> initialize the driver properly and is not modified. Make it const.
...
> @@ -2755,9 +2755,9 @@ static struct s3c24xx_serial_drv_data s5pv210_serial_drv_data = {
> },
> .fifosize = { 256, 64, 16, 16 },
> };
> -#define S5PV210_SERIAL_DRV_DATA ((kernel_ulong_t)&s5pv210_serial_drv_data)
> +#define S5PV210_SERIAL_DRV_DATA (&s5pv210_serial_drv_data)
> #else
> -#define S5PV210_SERIAL_DRV_DATA (kernel_ulong_t)NULL
> +#define S5PV210_SERIAL_DRV_DATA NULL

Yet, I still don't see why the switch from ulong->ptr happens in this
"constify it" patch?

thanks,
--
--
js
suse labs

\
 
 \ /
  Last update: 2022-03-07 09:34    [W:0.106 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site