lkml.org 
[lkml]   [2022]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 6/9] misc: smpro-errmon: Add Ampere's SMpro error monitor driver
On 24/12/2021 15:32, Greg Kroah-Hartman wrote:
> On Fri, Dec 24, 2021 at 11:13:49AM +0700, Quan Nguyen wrote:
>> This commit adds Ampere's SMpro error monitor driver for monitoring
>> and reporting RAS-related errors as reported by SMpro co-processor
>> found on Ampere's Altra processor family.
>>
>> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
>> ---
>> Change in v6:
>> + First introduced in v6 [Quan]
>>
>> drivers/mfd/smpro-mfd.c | 1 +
>> drivers/misc/Kconfig | 7 +
>> drivers/misc/Makefile | 1 +
>> drivers/misc/smpro-errmon.c | 571 ++++++++++++++++++++++++++++++++++++
>> 4 files changed, 580 insertions(+)
>> create mode 100644 drivers/misc/smpro-errmon.c
>
> You need Documentation/ABI/ updates when you add sysfs files. Please do
> that for your next version of this patch.
>

Thanks greg for the review,
Will update Documentation/ABI/testing/sysfs-* file in next version.

> Also remember that sysfs is only "one value per file", this driver seems
> to violate that in huge ways and is not ok.
>

These sysfs's does not return "multi value per file" but a single record
of data, one example is to return the 48-byte ARM RAS Vendor specific
error record.

Thanks
- Quan

\
 
 \ /
  Last update: 2022-03-07 09:33    [W:0.127 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site