lkml.org 
[lkml]   [2022]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] MIPS: Sanitise Cavium switch cases in TLB handler synthesizers
On Fri, Mar 04, 2022 at 09:13:11PM +0000, Maciej W. Rozycki wrote:
> It makes no sense to fall through to `break'. Therefore reorder the
> switch statements so as to have the Cavium cases first, followed by the
> default case, which improves readability and pacifies code analysis
> tools. No change in semantics, assembly produced is exactly the same.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Maciej W. Rozycki <macro@orcam.me.uk>
> Fixes: bc431d2153cc ("MIPS: Fix fall-through warnings for Clang")
> ---
> arch/mips/mm/tlbex.c | 23 ++++++++++-------------
> 1 file changed, 10 insertions(+), 13 deletions(-)

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]

\
 
 \ /
  Last update: 2022-03-07 13:28    [W:0.025 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site