[lkml]   [2022]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCHv5 01/30] x86/tdx: Detect running as a TDX guest in early boot
On Fri, Mar 04, 2022 at 07:47:37AM -0800, Dave Hansen wrote:
> Pure reviewer paranoia. :)

This is one of those things where when you look at them months, years
from now, you'd go "WTF was that added for?". Because it clearly is
there to catch, well, something you'll catch anyway in testing. Because
if you fail detecting you're running as a TDX guest, you'll know pretty
early about it.

So if it is pure paranoia, you should drop it. Or if there's at least
some merit for it being there, then slap a comment above it why that
check is happening.



 \ /
  Last update: 2022-03-04 17:03    [W:0.053 / U:1.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site