lkml.org 
[lkml]   [2022]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] bnx2x: replace usage of found with dedicated list iterator variable
From
Date
Hello,

> On 24. Mar 2022, at 11:46, Paolo Abeni <pabeni@redhat.com> wrote:
>
> Hello,
>
> On Thu, 2022-03-24 at 08:08 +0100, Jakob Koschel wrote:
>> To move the list iterator variable into the list_for_each_entry_*()
>> macro in the future it should be avoided to use the list iterator
>> variable after the loop body.
>>
>> To *never* use the list iterator variable after the loop it was
>> concluded to use a separate iterator variable instead of a
>> found boolean [1].
>>
>> This removes the need to use a found variable and simply checking if
>> the variable was set, can determine if the break/goto was hit.
>>
>> Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/
>> Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
>
> This looks like a purely net-next change, and we are in the merge
> window: net-next is closed for the time being. Could you please re-post
> after net-next re-open?

Thanks for letting me know, I'll re-post after net-next is reopened.

>
> Additionally, I suggest you to bundle the net-next patches in a single
> series, namely:

Are you saying having a single patchset for all /net and /drivers/net
related changes? This would also simplify a lot on my end.


>
> bnx2x: replace usage of found with dedicated list iterator variable
> octeontx2-pf: replace usage of found with dedicated list iterator variable
> sctp: replace usage of found with dedicated list iterator variable
> taprio: replace usage of found with dedicated list iterator variable
>
> that will simplify the processing, thanks!
>
> Paolo

Thanks,
Jakob

\
 
 \ /
  Last update: 2022-03-27 23:32    [W:0.069 / U:1.668 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site