lkml.org 
[lkml]   [2022]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v8 1/2] drivers: ddcci: upstream DDCCI driver
Hi Yusuf,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on linux/master linus/master lee-backlight/for-backlight-next v5.17 next-20220318]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Yusuf-Khan/drivers-ddcci-upstream-DDCCI-driver/20220321-111557
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 37fd83916da2e4cae03d350015c82a67b1b334c4
config: ia64-allmodconfig (https://download.01.org/0day-ci/archive/20220321/202203212212.7eOgDRf0-lkp@intel.com/config)
compiler: ia64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/42317fc284bbedc623892f2b20e404df80f8c393
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Yusuf-Khan/drivers-ddcci-upstream-DDCCI-driver/20220321-111557
git checkout 42317fc284bbedc623892f2b20e404df80f8c393
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/char/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

drivers/char/ddcci.c: In function 'ddcci_device_remove':
>> drivers/char/ddcci.c:1206:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
1206 | int ret = 0;
| ^~~


vim +/ret +1206 drivers/char/ddcci.c

1201
1202 static void ddcci_device_remove(struct device *dev)
1203 {
1204 struct ddcci_device *device = ddcci_verify_device(dev);
1205 struct ddcci_driver *driver;
> 1206 int ret = 0;
1207
1208 if (!device)
1209 return;
1210 driver = to_ddcci_driver(dev->driver);
1211
1212 if (driver->remove)
1213 ret = driver->remove(device);
1214 }
1215

--
0-DAY CI Kernel Test Service
https://01.org/lkp

\
 
 \ /
  Last update: 2022-03-21 15:35    [W:0.062 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site