lkml.org 
[lkml]   [2022]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] memory: samsung: exynos5422-dmc: Avoid some over memory allocation
On 20/03/2022 08:10, Christophe JAILLET wrote:
> 'dmc->counter' is a 'struct devfreq_event_dev **', so there is some
> over memory allocation. 'counters_size' should be computed with
> 'sizeof(struct devfreq_event_dev *)'.
>
> Use 'sizeof(*dmc->counter)' instead to fix it.
>
> While at it, use devm_kcalloc() instead of devm_kzalloc()+open coded
> multiplication.
>
> Fixes: 6e7674c3c6df ("memory: Add DMC driver for Exynos5422")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> devm_kmalloc_array() could also be used to save a few cycles because the
> array is fully initialized a few lines below.
> ---
> drivers/memory/samsung/exynos5422-dmc.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>

Thanks, looks good. I'll take it after merge window.


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-03-20 13:17    [W:2.029 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site