Messages in this thread |  | | From | Xiaomeng Tong <> | Subject | Re: [PATCH] ufs: remove an unneed NULL check on list iterator | Date | Sun, 20 Mar 2022 12:57:34 +0800 |
| |
On Sun, 20 Mar 2022 01:57:39 +0100, Jakob Koschel <jakobkoschel@gmail.com> wrote: > Maybe it make more sense to move that check after the loop body instead > of removing it completely? This code obviously does nothing in it's current > state but it's clear what the original intention was, so restoring that would > perhaps be better. > > But probably someone with more experience about this code can make the call >
This seems like a better choice, if it doesn't go against the author's original intention. I will fix it in PATCH v2, thanks.
-- Xiaomeng Tong
|  |