[lkml]   [2022]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] ufs: remove an unneed NULL check on list iterator
On Sun, 20 Mar 2022 01:57:39 +0100, Jakob Koschel <> wrote:
> Maybe it make more sense to move that check after the loop body instead
> of removing it completely? This code obviously does nothing in it's current
> state but it's clear what the original intention was, so restoring that would
> perhaps be better.
> But probably someone with more experience about this code can make the call

This seems like a better choice, if it doesn't go against the author's original
intention. I will fix it in PATCH v2, thanks.

Xiaomeng Tong

 \ /
  Last update: 2022-03-20 05:58    [W:0.068 / U:1.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site