Messages in this thread Patch in this message |  | | From | Ammar Faizi <> | Subject | [RFC PATCH v1 2/6] tools/nolibc: Make the entry point not weak for clang | Date | Sun, 20 Mar 2022 16:37:46 +0700 |
| |
Budilig with clang yields the following error: ``` <inline asm>:3:1: error: _start changed binding to STB_GLOBAL .global _start ^ 1 error generated. ``` Don't make the entry point weak if we're compiling with clang.
Cc: llvm@lists.linux.dev Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org> --- tools/include/nolibc/arch-aarch64.h | 2 ++ tools/include/nolibc/arch-arm.h | 2 ++ tools/include/nolibc/arch-i386.h | 2 ++ tools/include/nolibc/arch-mips.h | 2 ++ tools/include/nolibc/arch-riscv.h | 2 ++ tools/include/nolibc/arch-x86_64.h | 2 ++ 6 files changed, 12 insertions(+)
diff --git a/tools/include/nolibc/arch-aarch64.h b/tools/include/nolibc/arch-aarch64.h index 87d9e434820c..5084cd58b429 100644 --- a/tools/include/nolibc/arch-aarch64.h +++ b/tools/include/nolibc/arch-aarch64.h @@ -183,7 +183,9 @@ struct sys_stat_struct { /* startup code */ asm(".section .text\n" +#if !defined(__clang__) ".weak _start\n" +#endif ".global _start\n" "_start:\n" "ldr x0, [sp]\n" // argc (x0) was in the stack diff --git a/tools/include/nolibc/arch-arm.h b/tools/include/nolibc/arch-arm.h index 001a3c8c9ad5..b3f135a615a6 100644 --- a/tools/include/nolibc/arch-arm.h +++ b/tools/include/nolibc/arch-arm.h @@ -176,7 +176,9 @@ struct sys_stat_struct { /* startup code */ asm(".section .text\n" +#if !defined(__clang__) ".weak _start\n" +#endif ".global _start\n" "_start:\n" #if defined(__THUMBEB__) || defined(__THUMBEL__) diff --git a/tools/include/nolibc/arch-i386.h b/tools/include/nolibc/arch-i386.h index d7e4d53325a3..82bf797849ae 100644 --- a/tools/include/nolibc/arch-i386.h +++ b/tools/include/nolibc/arch-i386.h @@ -175,7 +175,9 @@ struct sys_stat_struct { * */ asm(".section .text\n" +#if !defined(__clang__) ".weak _start\n" +#endif ".global _start\n" "_start:\n" "pop %eax\n" // argc (first arg, %eax) diff --git a/tools/include/nolibc/arch-mips.h b/tools/include/nolibc/arch-mips.h index c9a6aac87c6d..719d3808614d 100644 --- a/tools/include/nolibc/arch-mips.h +++ b/tools/include/nolibc/arch-mips.h @@ -190,7 +190,9 @@ struct sys_stat_struct { /* startup code, note that it's called __start on MIPS */ asm(".section .text\n" +#if !defined(__clang__) ".weak __start\n" +#endif ".set nomips16\n" ".global __start\n" ".set noreorder\n" diff --git a/tools/include/nolibc/arch-riscv.h b/tools/include/nolibc/arch-riscv.h index bc10b7b5706d..a9704affd7de 100644 --- a/tools/include/nolibc/arch-riscv.h +++ b/tools/include/nolibc/arch-riscv.h @@ -184,7 +184,9 @@ struct sys_stat_struct { /* startup code */ asm(".section .text\n" +#if !defined(__clang__) ".weak _start\n" +#endif ".global _start\n" "_start:\n" ".option push\n" diff --git a/tools/include/nolibc/arch-x86_64.h b/tools/include/nolibc/arch-x86_64.h index a7b70ea51b68..f453f1a05a48 100644 --- a/tools/include/nolibc/arch-x86_64.h +++ b/tools/include/nolibc/arch-x86_64.h @@ -198,7 +198,9 @@ struct sys_stat_struct { * */ asm(".section .text\n" +#if !defined(__clang__) ".weak _start\n" +#endif ".global _start\n" "_start:\n" "pop %rdi\n" // argc (first arg, %rdi) -- Ammar Faizi
|  |