Messages in this thread Patch in this message |  | | From | trix@redhat ... | Subject | [PATCH] ipmi: initialize len variable | Date | Sun, 20 Mar 2022 06:59:54 -0700 |
| |
From: Tom Rix <trix@redhat.com>
Clang static analysis reports this issue ipmi_ssif.c:1731:3: warning: 4th function call argument is an uninitialized value dev_info(&ssif_info->client->dev, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
The 4th parameter is the 'len' variable. len is only set by a successful call to do_cmd(). Initialize to len 0.
Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/char/ipmi/ipmi_ssif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c index ba779f1abb5b2..f199cc1948446 100644 --- a/drivers/char/ipmi/ipmi_ssif.c +++ b/drivers/char/ipmi/ipmi_ssif.c @@ -1625,7 +1625,7 @@ static int ssif_probe(struct i2c_client *client, const struct i2c_device_id *id) unsigned char *resp; struct ssif_info *ssif_info; int rv = 0; - int len; + int len = 0; int i; u8 slave_addr = 0; struct ssif_addr_info *addr_info = NULL; -- 2.26.3
|  |