lkml.org 
[lkml]   [2022]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ufs: remove an unneed NULL check on list iterator
From
Date

> On 19. Mar 2022, at 05:26, Xiaomeng Tong <xiam0nd.tong@gmail.com> wrote:
>
> The list iterator is always non-NULL so it doesn't need to be checked.
> Thus just remove the unnecessary NULL check.
>
> Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
> ---
> drivers/scsi/ufs/ufshpb.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c
> index 2d36a0715..a3db0ad60 100644
> --- a/drivers/scsi/ufs/ufshpb.c
> +++ b/drivers/scsi/ufs/ufshpb.c
> @@ -869,12 +869,6 @@ static struct ufshpb_region *ufshpb_victim_lru_info(struct ufshpb_lu *hpb)
> struct ufshpb_region *rgn, *victim_rgn = NULL;
>
> list_for_each_entry(rgn, &lru_info->lh_lru_rgn, list_lru_rgn) {
> - if (!rgn) {
> - dev_err(&hpb->sdev_ufs_lu->sdev_dev,
> - "%s: no region allocated\n",
> - __func__);
> - return NULL;
> - }

Maybe it make more sense to move that check after the loop body instead
of removing it completely? This code obviously does nothing in it's current
state but it's clear what the original intention was, so restoring that would
perhaps be better.

But probably someone with more experience about this code can make the call

> if (ufshpb_check_srgns_issue_state(hpb, rgn))
> continue;
>
> --
> 2.17.1
>

Jakob

\
 
 \ /
  Last update: 2022-03-20 01:58    [W:0.069 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site