lkml.org 
[lkml]   [2022]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 3/6] ARM: dts: spear13xx: Fix sata node name
On 14-03-22, 15:50, Rob Herring wrote:
> On Mon, Mar 14, 2022 at 04:38:56PM +0100, Frank Wunderlich wrote:
> > Hi,
> >
> > thanks for for checking the spear-patch.
> >
> > > Gesendet: Montag, 14. März 2022 um 04:49 Uhr
> > > Von: "Viresh Kumar" <viresh.kumar@linaro.org>
> > >
> > > On 11-03-22, 22:03, Frank Wunderlich wrote:
> > > > From: Frank Wunderlich <frank-w@public-files.de>
> > > >
> > > > After converting the binding to yaml the node name does
> > > > not match the standard pattern, change it.
> > > >
> > > > arch/arm/boot/dts/spear1340-evb.dt.yaml: ahci@b1000000:
> > > > $nodename:0: 'ahci@b1000000' does not match '^sata(@.*)?$'
> > > > From schema: Documentation/devicetree/bindings/ata/ahci-platform.yaml
> > > >
> > > > Fixes: 07658d9a659b ("SPEAr13xx: Add dts and dtsi files")
> > >
> > > I don't think this is correct. The above patch is correct. The first
> > > patch in this series changes the names and that's where things break.
> >
> > it's right that my binding will break it, but the nodes are not named the right way.
> > And i used the commit that introduces the wrong node-names.
> > Maybe fixes-tag is wrong in this case.

The problem is that people will try and backport this patch of yours to earlier
stable kernels, because it has a Fixes tag, while the kernel isn't really broken
then and there is no need to backport anything. This patch (and others in
series) are just fine, just drop the Fixes tag.

> I'm pretty sure Viresh just meant the Fixes tag is not right.

Right.

--
viresh

\
 
 \ /
  Last update: 2022-03-15 03:50    [W:0.108 / U:0.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site