lkml.org 
[lkml]   [2022]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] ARM: dts: spear13xx: Update SPI dma properties
On 12-03-22, 23:36, Kuldeep Singh wrote:
> Reorder dmas and dma-names property for spi controller node to make it
> compliant with bindings.
>
> Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>

What about a fixes tag ?

> ---
> arch/arm/boot/dts/spear13xx.dtsi | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/spear13xx.dtsi b/arch/arm/boot/dts/spear13xx.dtsi
> index c87b881b2c8b..45f0b2a33e02 100644
> --- a/arch/arm/boot/dts/spear13xx.dtsi
> +++ b/arch/arm/boot/dts/spear13xx.dtsi
> @@ -284,9 +284,8 @@ spi0: spi@e0100000 {
> #size-cells = <0>;
> interrupts = <0 31 0x4>;
> status = "disabled";
> - dmas = <&dwdma0 4 0 0>,
> - <&dwdma0 5 0 0>;
> - dma-names = "tx", "rx";
> + dmas = <&dwdma0 5 0 0>, <&dwdma0 4 0 0>;
> + dma-names = "rx", "tx";

Why does the order matter here since we have dma-names anyway, which
was correct earlier ?

> };
>
> rtc@e0580000 {
> --
> 2.25.1

--
viresh

\
 
 \ /
  Last update: 2022-03-14 04:52    [W:0.112 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site