lkml.org 
[lkml]   [2022]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v11 1/2] dt-bindings: misc: Add iop yaml file for Sunplus SP7021
Date
Dear Krzysztof:

> On 12/03/2022 17:16, Tony Huang wrote:
> > Add iop yaml file for Sunplus SP7021
> >
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Tony Huang <tonyhuang.sunplus@gmail.com>
> > ---
> > Changes in v11:
> > - Addressed comments from krzysztof.
> >
> > .../devicetree/bindings/misc/sunplus,iop.yaml | 78
> ++++++++++++++++++++++
> > MAINTAINERS | 5 ++
> > 2 files changed, 83 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/misc/sunplus,iop.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/misc/sunplus,iop.yaml
> > b/Documentation/devicetree/bindings/misc/sunplus,iop.yaml
> > new file mode 100644
> > index 0000000..ad1c4be
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/misc/sunplus,iop.yaml
> > @@ -0,0 +1,78 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) # Copyright
> > +(C) Sunplus Ltd. Co. 2021 %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/misc/sunplus-iop.yaml#
>
> Still wrong path. This would be easily spotted if you test the bindings.
> Please run dt_binding_check. It's a requirement.

I have run dt_binding_check and don't see error.
Below is my modification
$id: http://devicetree.org/schemas/misc/sunplus,iop.yaml#

>
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Sunplus IOP(8051) controller
> > +
> > +maintainers:
> > + - Tony Huang <tonyhuang.sunplus@gmail.com>
> > +
> > +description: |
> > + Processor for I/O control, RTC wake-up procedure management,
> > + and cooperation with CPU&PMC in power management.
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - sunplus,sp7021-iop
> > +
> > + reg:
> > + items:
> > + - description: IOP registers regions
> > + - description: PMC registers regions
> > + - description: MOON0 registers regions
> > +
> > + reg-names:
> > + items:
> > + - const: iop
> > + - const: iop_pmc
> > + - const: moon0
> > +
> > + interrupts:
> > + items:
> > + - description: IOP_INT0. IOP to system Interrupt 0.
> > + Sent by IOP to system RISC.
> > + - description: IOP_INT1. IOP to System Interrupt 1.
> > + Sent by IOP to system RISC.
> > +
> > + memory-region:
> > + maxItems: 1
> > +
> > + wakeup-gpios:
> > + description: When the linux kernel system is powered off.
> > + 8051 is always powered. 8051 cand receive external signals
> > + according to this gpio pin. 8051 receives external signal
> > + through gpio pin. 8051 can power on linux kernel system.
> > + maxItems: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - reg-names
> > + - clocks
> > + - interrupts
> > + - memory-region
> > + - wakeup-gpios
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/irq.h>
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > + #include <dt-bindings/gpio/gpio.h>
> > + iop: iop@9c000400 {
> > + compatible = "sunplus,sp7021-iop";
> > + reg = <0x9c000400 0x80>, <0x9c003100 0x80>, <0x9c000000
> 0x80>;
> > + reg-names = "iop", "iop_pmc", "moon0";
> > + clocks = <&clkc 0x14>;
> > + interrupt-parent = <&intc>;
> > + interrupts = <41 IRQ_TYPE_LEVEL_HIGH>, <42
> IRQ_TYPE_LEVEL_HIGH>;
> > + memory-region = <&iop_reserve>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&iop_pins>;
> > + wakeup-gpios = <&pctl 1 GPIO_ACTIVE_HIGH>;
> > + };
> > \ No newline at end of file

I will modify.

\
 
 \ /
  Last update: 2022-03-14 02:38    [W:0.056 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site