[lkml]   [2022]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] media: stkwebcam: move stk_camera_read_reg() scratch buffer to struct stk_camera

On 3/13/22 8:11 AM, Pavel Skripkin wrote:
> Hi Tom,
> On 3/13/22 02:48, Tom Rix wrote:
>> These do show up in my usual static analysis and it why I was looking at
>> this file.
>> And was sidetracked by the short malloc.
>> Unfortunately I looked and there are many other similar instances
>> treewide ~100
> Most of them are in very old drivers and I don't think they ever be
> fixed. I've looked into one bug reported by syzkaller and there was
> like 30 calls w/o proper error handling in one driver. Redoing whole
> driver logic without access to hw seems dangerous :))

From the checkpatch change below, there are about 150 dinky allocs treewide

Here is a refactoring

>> These aren't caught in checkpatch, so working on that..
> I think, it's not checkpath responsibility. Maybe it worth adding such
> check to smatch. I tried to implement such checker, but never finished
> it :(
Poking new development to not do dinky allocs I think is worth it, here
is my checkpatch patch

steal the regex for smatch.


> With regards,
> Pavel Skripkin

 \ /
  Last update: 2022-03-13 16:37    [W:0.746 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site