Messages in this thread |  | | Date | Sat, 12 Mar 2022 10:09:41 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] clocksource: acpi_pm: fix return value of __setup handler |
| |
On Tue, Mar 08, 2022 at 08:03:01PM -0800, Randy Dunlap wrote: > __setup() handlers should return 1 to obsolete_checksetup() in > init/main.c to indicate that the boot option has been handled. > A return of 0 causes the boot option/value to be listed as an Unknown > kernel parameter and added to init's (limited) environment strings. > > The __setup() handler interface isn't meant to handle negative return > values -- they are non-zero, so they mean "handled" (like a return > value of 1 does), but that's just a quirk. So return 1 from > parse_pmtmr(). Also print a warning message if kstrtouint() returns > an error. > > Fixes: 60e3bf14d4e2 ("clocksource: clean up parse_pmtmr()")
I was wondering why I was CC'd on this.
This fixes tag is wrong... My patch just cleaned up the function. The original code returned negative error codes already.
regards, dan carpenter
|  |