[lkml]   [2022]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] clocksource: acpi_pm: fix return value of __setup handler
On Tue, Mar 08, 2022 at 08:03:01PM -0800, Randy Dunlap wrote:
> __setup() handlers should return 1 to obsolete_checksetup() in
> init/main.c to indicate that the boot option has been handled.
> A return of 0 causes the boot option/value to be listed as an Unknown
> kernel parameter and added to init's (limited) environment strings.
> The __setup() handler interface isn't meant to handle negative return
> values -- they are non-zero, so they mean "handled" (like a return
> value of 1 does), but that's just a quirk. So return 1 from
> parse_pmtmr(). Also print a warning message if kstrtouint() returns
> an error.
> Fixes: 60e3bf14d4e2 ("clocksource: clean up parse_pmtmr()")

I was wondering why I was CC'd on this.

This fixes tag is wrong... My patch just cleaned up the function.
The original code returned negative error codes already.

dan carpenter

 \ /
  Last update: 2022-03-12 08:11    [W:0.072 / U:0.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site