[lkml]   [2022]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] sparc: vDSO: fix return value of __setup handler
On Fri, Mar 11, 2022 at 08:21:44PM -0800, Randy Dunlap wrote:
> __setup() handlers should return 1 to obsolete_checksetup() in
> init/main.c to indicate that the boot option has been handled.
> A return of 0 causes the boot option/value to be listed as an Unknown
> kernel parameter and added to init's (limited) argument or environment
> strings. Also, error return codes don't mean anything to
> obsolete_checksetup() -- only non-zero (usually 1) or zero.
> So return 1 from vdso_setup().
> Fixes: 62d6f3b7b85e ("sparc: vDSO: Silence an uninitialized variable warning")

This fixes tag is wrong. My patch did not change the return values at

dan carpenter

 \ /
  Last update: 2022-03-12 08:08    [W:0.334 / U:0.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site