Messages in this thread |  | | Date | Sun, 13 Mar 2022 00:43:08 +0300 | Subject | Re: [PATCH] staging: android: ashmem: Declared file operation with const keyword Warning found by checkpatch.pl script. | From | Pavel Skripkin <> |
| |
Hi Shaikh,
On 3/12/22 23:41, shaikh kamal wrote: > Signed-off-by: shaikh kamal <shaikhkamal2012@gmail.com> > --- > drivers/staging/android/ashmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c > index ddbde3f8430e..4c6b420fbf4d 100644 > --- a/drivers/staging/android/ashmem.c > +++ b/drivers/staging/android/ashmem.c > @@ -377,7 +377,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr, > > static int ashmem_mmap(struct file *file, struct vm_area_struct *vma) > { > - static struct file_operations vmfile_fops; > + static const struct file_operations vmfile_fops; > struct ashmem_area *asma = file->private_data; > int ret = 0; >
Are you sure this patch compiles? vmfile_fops is overrided few lines below
odd checkpatch.pl warning...
With regards, Pavel Skripkin
|  |